Switch to Zipkin v2 span format #141
Conversation
| @@ -28,24 +28,19 @@ def resolved_ip_address?(ip_string) | |||
| ip_string.to_i.to_s == ip_string | |||
| end | |||
|
|
|||
| def each_annotation(spans, &block) | |||
| def each_endpoint(spans, &block) | |||
There was a problem hiding this comment.
maybe add a comment about what this is doing? I'm guessing it is lazy parsing?
There was a problem hiding this comment.
I think this comment is explaining:
zipkin-ruby/lib/zipkin-tracer/hostname_resolver.rb
Lines 5 to 6 in f0435f9
| @@ -55,12 +55,11 @@ def annotate_plugin(span, env, status, response_headers, response_body) | |||
|
|
|||
| def trace!(span, zipkin_env, &block) | |||
| trace_request_information(span, zipkin_env) | |||
| span.record(Trace::Annotation::SERVER_RECV) | |||
| span.kind = Trace::Span::Kind::SERVER | |||
There was a problem hiding this comment.
is there a way to tell if the incoming span ID was shared (from b3 headers)? if so, add span.shared=true
There was a problem hiding this comment.
updated in 1139cc5
lib/zipkin-tracer/trace.rb
Outdated
| METHOD = "http.method".freeze | ||
| PATH = "http.path".freeze | ||
| STATUS = "http.status".freeze | ||
| LOCAL_COMPONENT = "lc".freeze |
There was a problem hiding this comment.
ls is no longer needed unless there's a value for it. sometimes we had "lc"->"" just to add an endpoint to a span.
There was a problem hiding this comment.
It seems we are still using it in our library. Added TODO in 2cd021e
lib/zipkin-tracer/trace.rb
Outdated
| module Tag | ||
| METHOD = "http.method".freeze | ||
| PATH = "http.path".freeze | ||
| STATUS = "http.status".freeze |
There was a problem hiding this comment.
this is wrong, it should be http.status_code though possibly was always incorrect here
There was a problem hiding this comment.
updated d4b6254
|
It seems we always have zipkin-ruby/lib/zipkin-tracer/trace.rb Lines 213 to 215 in 76ea494 |
|
I am going to merge with the |
|
agreed. this is a huge help
…On Fri, Mar 8, 2019, 1:07 PM Jordi Polo Carres ***@***.***> wrote:
I am going to merge with the lc TODO. Moving to V2 is a huge step forward
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#141 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAD615i_Yw2vNk-1vMgyTM1VSWiarDj2ks5vUqbzgaJpZM4birS->
.
|
Use the simplified Zipkin v2 span format to send traces to Zipkin server.
See openzipkin/zipkin#1499 for details
@cabbott @jcarres-mdsol @jfeltesse-mdsol @ssteeg-mdsol @piao-mdsol @adriancole