Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipkin-instrumentation-express update typings #445

Closed
wants to merge 1 commit into from
+1 −1
Closed

zipkin-instrumentation-express update typings #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/zipkin-instrumentation-express/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {Tracer} from 'zipkin';
* go to the correct spans
*/
export declare function expressMiddleware(
options: {tracer: Tracer, port?: number}
options: {tracer: Tracer, serviceName: string, port?: number}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we intentionally don't document this as it is usually a mistake to have a difference between middleware service name and tracer. this causes graphs to mess up. You may notice that there are a few pull requests to change readmes to not use this. Also, I except once we figure out how deprecation works, we'd remove it eventually.

What impact is it causing to leave this out?

): Handler;

export declare function wrapExpressHttpProxy(
Expand Down