[#57] Removes http header binary annotation in spans. #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
force-pushed
the
removes_unnecessary_debug_tag
branch
from
6a8a05b to
93620ad
Compare
codefromthecrypt
approved these changes
Jun 28, 2018
|
cool on non appveyor green |
jcchavezs
force-pushed
the
removes_unnecessary_debug_tag
branch
from
93620ad to
5a20add
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
'X-B3-Flags'from the binary annotations (aka tags): actual removal is in https://github.com/openzipkin/zipkin-js/compare/removes_unnecessary_debug_tag?expand=1#diff-13acaf8526b6f17f74c05c209a6c833c and the rest are tests.Ping @adriancole @eirslett