Adds definition of messaging annotations #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per openzipkin/zipkin#1654 Notably, this also says messaging spans should never share a span ID.
|
here's the corresponding server code work in progress openzipkin/zipkin#1677 |
shakuzen
approved these changes
Aug 1, 2017
codefromthecrypt
pushed a commit
that referenced
this pull request
Aug 15, 2017
Per openzipkin/zipkin#1654 Notably, this also says messaging spans should never share a span ID.
This was referenced Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per openzipkin/zipkin#1654
Notably, this also says messaging spans should never share a span ID.
This is in support of the simplified model known as span2 which will
use span.kind=PRODUCER|CONSUMER to accomplish the same. We
are mapping back to annotations because most instrumentation and
storage will need to for a while.
cc @jcarres-mdsol @ImFlog @devinsba @dgrabows @lijunyong @marcingrzejszczak @sslavic @mbogoevici @hammett