Removes tracers and extensions not updated in 4 years #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,18 +1,12 @@ | |||
| - type: Storage | |||
| module: >- | |||
| [zipkin-logzio](https://github.com/logzio/zipkin-logzio) | |||
| [zipkin-storage-forwarder](https://github.com/openzipkin-contrib/zipkin-storage-forwarder) | |||
There was a problem hiding this comment.
also added forwarder
anuraaga
approved these changes
Jan 11, 2024
reta
reviewed
Jan 11, 2024
| @@ -68,3 +68,13 @@ | |||
| transports: "http, log file" | |||
There was a problem hiding this comment.
@codefromthecrypt I run into Rust one recently [1], do you think we could add it? (apologies if it is there already but I haven't find it)
There was a problem hiding this comment.
sounds good. Usually we don't add things unless we maintain them, or one of the authors says ok. @sfackler sound good?
There was a problem hiding this comment.
@reta once we merge this, make a separate PR so that watchers can notice!
|
I am fixing jekyll |
reta
approved these changes
Jan 11, 2024
codefromthecrypt
force-pushed
the
remove
branch
2 times, most recently
from
50d3381 to
01e3b71
Compare
|
I extracted the bloody knuckles of ruby stuff to a separate PR #176 |
shakuzen
approved these changes
Jan 11, 2024
This removes extensions and tracers that are archived or implicitly via abandonment for 4 years. Folks can add more if they like. I also added brave-cassandra as it was missing and there are a few more official ones maybe @reta can help add. @shakuzen there's nothing here for micrometer tracing so if you like, add a follow-up PR for community supported tracers and instrumentation. @jack-berg there's nothing here for OTEL, so if you like, you can add a follow-up PR for communit supported tracers and instrumentation, as well alternative servers as OTLP as I understand accepts zipkin format. https://github.com/openzipkin/openzipkin.github.io/blob/master/pages/extensions_choices.md#alternative-servers Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
remove
branch
from
01e3b71 to
6acb7f8
Compare
|
wow more ✅ than any PR in recent history ;) thanks for the look folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes extensions and tracers that are archived or implicitly via abandonment for 4 years. If any become maintained again, they can be re-added as necessary.
Folks can add more if they like. I also added brave-cassandra as it was missing and there are a few more official ones maybe @reta can help add.
@shakuzen there's nothing here for micrometer tracing so if you like, add a follow-up PR for community supported tracers and instrumentation.
@jack-berg there's nothing here for OTEL, so if you like, you can add a follow-up PR for communit supported tracers and instrumentation, as well alternative servers as OTLP as I understand accepts zipkin format.
https://github.com/openzipkin/openzipkin.github.io/blob/master/pages/extensions_choices.md#alternative-servers