Introduces SpanRecord type and clarifies a PendingSpan concept #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we had some elements that weren't well organized about not-yet- reported spans. Formerly, there was `MutableSpan`, `MutableSpanMap`, and `Recorder`. These were internal and replaced by still internal types of: * SpanRecord: mutable type which can become a Zipkin span. * PendingSpan: SpanRecord and a clock appropriate for a trace context. * PendingSpans: repository allowing lookup and removal by trace context. These are clarifications and optimizations of code that existed before. Notably, this removes the need to re-build a zipkin span to customize it before reporting, or to need a zipkin span at all when reporting to metrics or other aggregations. Future work on that will happen in later pull requests. There is no public api change involved as all work is currently internal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we had some elements that weren't well organized about not-yet-
reported spans. Formerly, there was
MutableSpan,MutableSpanMap, andRecorder. These were internal and replaced by still internal types of:These are clarifications and optimizations of code that existed before.
Notably, this removes the need to re-build a zipkin span to customize it
before reporting, or to need a zipkin span at all when reporting to
metrics or other aggregations. Future work on that will happen in later
pull requests. There is no public api change involved as all work is
currently internal.
See #557