Adds HttpAdapter.methodFromResponse for route-based span names #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adding a test for http options to this |
codefromthecrypt
force-pushed
the
method-in-name
branch
2 times, most recently
from
ab56ffd to
024f566
Compare
Span names like "/users/:userId" now include the method like "delete /users/:userId" This changes the route-based naming convention to include the http method and fixes some glitches not detected before. To support this, we need to make the http method visible in response parsing phase.
codefromthecrypt
force-pushed
the
method-in-name
branch
from
024f566 to
c14c6f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Span names like "/users/:userId" now include the method like
"delete /users/:userId"
This changes the route-based naming convention to include the http
method and fixes some glitches not detected before. To support this,
we need to make the http method visible in response parsing phase.
See openzipkin/zipkin#1874 (comment)