Adds rationale and notes around comma-separated HTTP headers #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,6 +60,15 @@ attempting to do that would limit the applicability of Brave, which is an anti- | |||
| goal. Instead, we choose to use nothing except floor Java version features, | |||
| currently Java 6. | |||
|
|
|||
| Here's an example of when things that seem right aren't. We once dropped our | |||
There was a problem hiding this comment.
this is not about HTTP, but don't feel like moving it to another PR ...
| responsibility of the `Propagation` implementation. Hence, the `Injector`, | ||
| which knows format rules, should do comma joining when valid. | ||
|
|
||
| Some think that sending a header in comma-separated format, implies a receiver |
There was a problem hiding this comment.
I added this point because it is a common fantasy
NersesAM
reviewed
May 11, 2020
NersesAM
reviewed
May 11, 2020
|
Thanks for the help @NersesAM ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.