How should we name a span when the route is empty on status 200

[codefromthecrypt]

I noticed with an OPTIONS request that the span name defaulted to "options" not including a matched template. This is due to no route being defined for that method (though the OPTIONS request was valid). How should be map this? "options not_found" as there's no route defined for this? or leave it as "options" relegating to the path to clarify it.

[basvanbeek]

I think the most common case for OPTIONS is that most people handle this in a generic middleware for CORS purposes and do not really have any routing distinctions.

I even question if in many cases tracing OPTIONS requests is just pure added noise.

So my preference would be 'no_route' over 'not_found' as not found signals there typically are different routes for OPTIONS requests.

[codefromthecrypt]

Good point. Maybe we dont have to solve particularly for this. At any rate the span name "options" is fixed cardinality and no worse than before.

…

On 23 Feb 2018 4:37 pm, "Bas van Beek" ***@***.***> wrote: I think the most common case for OPTIONS is that most people handle this in a generic middleware for CORS purposes and do not really have any routing distinctions. I even question if in many cases tracing OPTIONS requests is just pure added noise. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#621 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD61x7WsAQjVgnae7uy5urKDY08Zm0vks5tXnjdgaJpZM4SQhvP> .

[codefromthecrypt]

so this will end up as default ("get")