-
Notifications
You must be signed in to change notification settings - Fork 714
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reverts permittance of duplicate handlers (#1001)
It is a worse bug to allow duplicate handlers than it is to allow duplicate configuration. Duplicate handlers translate directly into runtime overhead, particularly as there is special casing for one handler. Throwing an exception was suggested here #961, but that is not a good choice as it would almost certainly lead to someone having to do an emergency release to undo it. This changes to logging on dupe, so that we don't propagate this problem into future work such as collector handlers. See openzipkin/zipkin#2807 (comment)
- Loading branch information
1 parent
5f2d6d1
commit 75dab65
Showing
2 changed files
with
17 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters