Adding flags to enable components #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wait this is a sneaky big feature! you mean this will allow replacement of the spark job, right? Maybe add to README: using as an alternative to zipkin-dependencies |
module/src/main/java/zipkin2/module/storage/kafka/ZipkinKafkaStorageProperties.java
Outdated
Show resolved
Hide resolved
I think so! :) we could add modules to downstream dependencies to cassandra/elasticsearch/etc later. |
|
@adriancole did some vars renaming, add docs and created a docker-compose example for only dependency processing. let me know wdyt |
jeqo
commented
Oct 24, 2019
|
@adriancole I'll be back on Monday, looking forward to your feedback :) |
codefromthecrypt
approved these changes
Oct 30, 2019
module/src/main/resources/zipkin-server-kafka-only-dependencies.yml
Outdated
Show resolved
Hide resolved
|
Thanks for the review @adriancole ! I will merge this and upgrade to latest zipkin on a minor release. |
|
bravo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to effectively disable certain components (aggregation, trace/dependency store) we require additional flags. This will help to users that only want to use certain part of Kafka Storage, as dependency aggregation, then we can disable other components.
Other use-case is when deploying aggregation and storage in separate components. And also to apply
searchEnabledflag properly on the storage, to disable onlyGET /traces?paramsquery.Changes: