This repository has been archived by the owner on Nov 27, 2017. It is now read-only.
Defaults ZIPKIN_BASE_URL to same origin in production config #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, you couldn't change `ZIPKIN_BASE_URL` when developing, and the production build was hard-targeted to localhost. This flips the preference, so that the production build is fixed to a more realistic same-origin policy, while development can be changed easily. See #37
|
cc @llinder with this, docker works now. |
codefromthecrypt
pushed a commit
to openzipkin-attic/docker-zipkin
that referenced
this pull request
Apr 14, 2017
This changes the zipkin-ui image to rewrite nginx configuration on start based on the `ZIPKIN_BASE_URL` variable, which defaults to 'http://zipkin:9411'. Users can change this variable to point at a different zipkin host such as a kubernetes pod. See openzipkin-attic/zipkin-ui#38 Fixes #134
codefromthecrypt
pushed a commit
to openzipkin-attic/docker-zipkin
that referenced
this pull request
Apr 14, 2017
This changes the zipkin-ui image to rewrite nginx configuration on start based on the `ZIPKIN_BASE_URL` variable, which defaults to 'http://zipkin:9411'. Users can change this variable to point at a different zipkin host such as a kubernetes pod. See openzipkin-attic/zipkin-ui#38 Fixes #134
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, you couldn't change
ZIPKIN_BASE_URLwhen developing, andthe production build was hard-targeted to localhost. This flips the
preference, so that the production build is fixed to a more realistic
same-origin policy, while development can be changed easily.
See #37