Cleanup Raid-Z Typo fixes #13834
Merged
Cleanup Raid-Z Typo fixes #13834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Yao <[email protected]>
behlendorf
approved these changes
Sep 2, 2022
beren12
pushed a commit
to beren12/zfs
that referenced
this pull request
Sep 19, 2022
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Richard Yao <[email protected]> Closes openzfs#13834
datacore-rm
pushed a commit
to DataCoreSoftware/openzfs
that referenced
this pull request
Oct 4, 2022
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Richard Yao <[email protected]> Closes openzfs#13834
datacore-rm
pushed a commit
to DataCoreSoftware/openzfs
that referenced
this pull request
Oct 13, 2022
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Richard Yao <[email protected]> Closes openzfs#13834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I found these typos earlier in the year when investigating the possibility of making raid-z faster on architectures that do not have optimized assembly. They remained in a local branch until now. I found them last night and decided to send the patch.
Description
It is just two fixes to comments and replacement of two constants with preprocessor definitions that mean the same thing. The preprocessor definitions should have been used in the first place to make the code more readable.
How Has This Been Tested?
No testing was done. It is not necessary for this kind of cleanup.
Types of changes
Checklist:
Signed-off-by.