Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected oversight in ZERO_RANGE behavior - 2.1 backport #13354

Merged

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Backport of #13338 for the zfs-2.1.5-staging branch.

Description

    Corrected oversight in ZERO_RANGE behavior
    
    It turns out, no, in fact, ZERO_RANGE and PUNCH_HOLE do
    have differing semantics in some ways - in particular,
    one requires KEEP_SIZE, and the other does not.
    
    Also added a zero-range test to catch this, corrected a flaw
    that made the punch-hole test succeed vacuously, and a typo
    in file_write.

How Has This Been Tested?

Clean cherry pick, see #13338 for additional details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

It turns out, no, in fact, ZERO_RANGE and PUNCH_HOLE do
have differing semantics in some ways - in particular,
one requires KEEP_SIZE, and the other does not.

Also added a zero-range test to catch this, corrected a flaw
that made the punch-hole test succeed vacuously, and a typo
in file_write.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#13329 
Closes openzfs#13338
@behlendorf behlendorf added Status: Code Review Needed Ready for review and testing Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 20, 2022
@behlendorf behlendorf merged commit c220771 into openzfs:zfs-2.1.5-staging Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants