Skip to content

Commit

Permalink
Linux 5.2 compat: Remove config/kernel-set-fs-pwd.m4
Browse files Browse the repository at this point in the history
This failed on 5.2-rc1 with "error: unknown" message, for set_fs_pwd()
not being visible in both const and non-const tests.

This is caused by torvalds/linux@83da1bed86. It's configurable,
but we would want to be able to compile with default kbuild setting.

set_fs_pwd() has never been exported with exception of some distro
kernels, and set_fs_pwd() wasn't used in ZoL to begin with. The test
result was used for a spl function vn_set_fs_pwd().

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: loli10K <[email protected]>
Signed-off-by: Tomohiro Kusumi <[email protected]>
Closes #8777
  • Loading branch information
kusumi authored and behlendorf committed Jun 7, 2019
1 parent df717bb commit 8ec352b
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 44 deletions.
39 changes: 0 additions & 39 deletions config/kernel-set-fs-pwd.m4

This file was deleted.

1 change: 0 additions & 1 deletion config/kernel.m4
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ AC_DEFUN([ZFS_AC_CONFIG_KERNEL], [
ZFS_AC_KERNEL_CONFIG
ZFS_AC_KERNEL_CTL_NAME
ZFS_AC_KERNEL_PDE_DATA
ZFS_AC_KERNEL_SET_FS_PWD_WITH_CONST
ZFS_AC_KERNEL_2ARGS_VFS_FSYNC
ZFS_AC_KERNEL_FS_STRUCT_SPINLOCK
ZFS_AC_KERNEL_KUIDGID_T
Expand Down
4 changes: 0 additions & 4 deletions module/spl/spl-vnode.c
Original file line number Diff line number Diff line change
Expand Up @@ -643,11 +643,7 @@ EXPORT_SYMBOL(areleasef);


static void
#ifdef HAVE_SET_FS_PWD_WITH_CONST
vn_set_fs_pwd(struct fs_struct *fs, const struct path *path)
#else
vn_set_fs_pwd(struct fs_struct *fs, struct path *path)
#endif /* HAVE_SET_FS_PWD_WITH_CONST */
{
struct path old_pwd;

Expand Down

0 comments on commit 8ec352b

Please sign in to comment.