Update deviceController to reconcile the deviceService between the openyurt and edge #4
Conversation
| @@ -18,6 +18,15 @@ package v1alpha1 | |||
|
|
|||
| import ( | |||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
| clusterv1 "sigs.k8s.io/cluster-api/api/v1alpha4" | |||
There was a problem hiding this comment.
need to update copyright: kubernetes --> OpenYurt
There was a problem hiding this comment.
Thanks for reminding, the license header is changed.
controllers/deviceprofile_syncer.go
Outdated
| "github.com/edgexfoundry/go-mod-core-contracts/models" | ||
| "github.com/go-logr/logr" | ||
| coremetacli "github.com/openyurtio/device-controller/clients/core-metadata" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
|
|
There was a problem hiding this comment.
please add license header. all others files should be check.
There was a problem hiding this comment.
Thanks for reminding, the license headers are all added.
|
@qclc need to fix conflicting files. |
|
@rambohe-ch all the conflicting files are fixed, please review. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: qclc, rambohe-ch The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
AdminStatefield of deviceServiceNote: Can't support update other field of deviceService yet.