Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

support edgex 2.1 #30

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

wawlian
Copy link
Contributor

@wawlian wawlian commented May 17, 2022

What type of PR is this?
Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind feature
/sig iot

What this PR does / why we need it:
Supports EdgeX Foundry Jakarta Version. EdgeX Jakarta is the first LTS version and be widely considered as a production ready version.

Which issue(s) this PR fixes:
None

Does this PR introduce a user-facing change?
Yes。Since EdgeX Jakarta version switched to api v2, so not only the internal interaction logic between OpenYurt and EdgeX, but also the CRDs changed accordingly. The mainly user-facing changes are list as below:

We removed ValueDescriptor CRD
Some fields of Device、DeviceService、DeviceProfile has changed,users can refer to the CRD yamls in the config/crd/bases directory

  1. Supports EdgeX 2.1 integration.
  2. Adjust CRDs of Device、DeviceService、DeviceProfile.
  3. Removed ValueDescriptor.

@openyurt-bot
Copy link

@wawlian: The label(s) kind/feature, sig/iot cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind feature
/sig iot

What this PR does / why we need it:
Supports EdgeX Foundry Jakarta Version. EdgeX Jakarta is the first LTS version and be widely considered as a production ready version.

Which issue(s) this PR fixes:
None

Does this PR introduce a user-facing change?
Yes。Since EdgeX Jakarta version switched to api v2, so not only the internal interaction logic between OpenYurt and EdgeX, but also the CRDs changed accordingly. The mainly user-facing changes are list as below:

We removed ValueDescriptor CRD
Some fields of Device、DeviceService、DeviceProfile has changed,users can refer to the CRD yamls in the config/crd/bases directory

  1. Supports EdgeX 2.1 integration.
  2. Adjust CRDs of Device、DeviceService、DeviceProfile.
  3. Removed ValueDescriptor.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wawlian
Copy link
Contributor Author

wawlian commented May 17, 2022

/assign @qclc

Copy link
Member

@qclc qclc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the modification of CRD to the crd.yaml file (this file is used by users to quickly deploy the CRD related to yurt-device-controller in the cluster) @wawlian

@wawlian
Copy link
Contributor Author

wawlian commented May 20, 2022

@qclc crd file updated

@qclc
Copy link
Member

qclc commented May 20, 2022

/lgtm

@qclc
Copy link
Member

qclc commented May 20, 2022

/approve

@openyurt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qclc, wawlian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit 41bbb59 into openyurtio:main May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants