-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
@Rudolf1998 , the current unit test coverage is only about 18.8% basing on your PR, which can not meet the 70% target, could you please optimize it to improve the ratio? thanks! |
@zzguang I think 70% test coverage for the entire |
Okay, agree with you to implement the mock test in future. |
/approve |
/lgtm |
9963f2e
to
88b0eb1
Compare
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=========================================
+ Coverage 7.78% 9.34% +1.55%
=========================================
Files 17 18 +1
Lines 1901 2258 +357
=========================================
+ Hits 148 211 +63
- Misses 1724 2010 +286
- Partials 29 37 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@Rudolf1998 please check ci/golangci-lint error info . |
/lgtm |
Fixes #76 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadisi, Rudolf1998, zzguang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note