-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beta.kubernetes.io is deprecated, use kubernetes.io instead #969
beta.kubernetes.io is deprecated, use kubernetes.io instead #969
Conversation
Warning: spec.template.spec.nodeSelector[beta.kubernetes.io/arch]: deprecated since v1.14; use "kubernetes.io/arch" instead Warning: spec.template.spec.nodeSelector[beta.kubernetes.io/os]: deprecated since v1.14; use "kubernetes.io/os" instead Signed-off-by: Tomoya Fujita <[email protected]>
Welcome @fujitatomoya! It looks like this is your first PR to openyurtio/openyurt 🎉 |
We have @zhaodiaoer working on #958, so we can discuss there. |
Codecov Report
@@ Coverage Diff @@
## master #969 +/- ##
==========================================
+ Coverage 40.30% 44.44% +4.13%
==========================================
Files 80 83 +3
Lines 11003 11370 +367
==========================================
+ Hits 4435 5053 +618
+ Misses 6241 5881 -360
- Partials 327 436 +109
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@fujitatomoya Thank you for posting pull request to replace meanwhile, the owner of #958 have no response for nearly a week. so how about fix the helm charts instead of |
@rambohe-ch thanks for the quick response, will try that in this week. |
Signed-off-by: Tomoya Fujita <[email protected]>
@rambohe-ch see 2be849b |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fujitatomoya, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
deprecated resource should not be used to avoid warning.
Which issue(s) this PR fixes:
avoid the following deprecation warning.
Special notes for your reviewer:
N.A
Does this PR introduce a user-facing change?
None