Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beta.kubernetes.io is deprecated, use kubernetes.io instead #969

Merged

Conversation

fujitatomoya
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

deprecated resource should not be used to avoid warning.

Which issue(s) this PR fixes:

avoid the following deprecation warning.

root@tomoyafujita:~/openyurt# kubectl apply -f config/setup/yurt-tunnel-server.yaml
clusterrole.rbac.authorization.k8s.io/tunnel-proxy-client created
clusterrolebinding.rbac.authorization.k8s.io/tunnel-proxy-client created
clusterrole.rbac.authorization.k8s.io/yurt-tunnel-server created
clusterrolebinding.rbac.authorization.k8s.io/yurt-tunnel-server created
serviceaccount/yurt-tunnel-server created
service/x-tunnel-server-svc created
service/x-tunnel-server-internal-svc created
configmap/yurt-tunnel-server-cfg created
Warning: spec.template.spec.nodeSelector[beta.kubernetes.io/arch]: deprecated since v1.14; use "kubernetes.io/arch" instead
Warning: spec.template.spec.nodeSelector[beta.kubernetes.io/os]: deprecated since v1.14; use "kubernetes.io/os" instead
deployment.apps/yurt-tunnel-server created

Special notes for your reviewer:

N.A

Does this PR introduce a user-facing change?

None

  Warning: spec.template.spec.nodeSelector[beta.kubernetes.io/arch]: deprecated since v1.14; use "kubernetes.io/arch" instead
  Warning: spec.template.spec.nodeSelector[beta.kubernetes.io/os]: deprecated since v1.14; use "kubernetes.io/os" instead

Signed-off-by: Tomoya Fujita <[email protected]>
@openyurt-bot
Copy link
Collaborator

Welcome @fujitatomoya! It looks like this is your first PR to openyurtio/openyurt 🎉

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Aug 25, 2022
@Congrool
Copy link
Member

We have @zhaodiaoer working on #958, so we can discuss there.
Thanks for your contribution.

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #969 (2be849b) into master (fa083f8) will increase coverage by 4.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
+ Coverage   40.30%   44.44%   +4.13%     
==========================================
  Files          80       83       +3     
  Lines       11003    11370     +367     
==========================================
+ Hits         4435     5053     +618     
+ Misses       6241     5881     -360     
- Partials      327      436     +109     
Flag Coverage Δ
unittests 44.44% <ø> (+4.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurthub/server/certificate.go 0.00% <0.00%> (ø)
pkg/yurthub/server/server.go 0.00% <0.00%> (ø)
pkg/yurthub/server/nonresource.go 31.08% <0.00%> (ø)
pkg/yurthub/cachemanager/cache_manager.go 68.22% <0.00%> (+0.07%) ⬆️
pkg/yurthub/util/util.go 21.37% <0.00%> (+0.86%) ⬆️
pkg/yurtadm/util/edgenode/util.go 9.02% <0.00%> (+7.35%) ⬆️
pkg/yurtctl/util/kubernetes/apply_addons.go 14.61% <0.00%> (+14.61%) ⬆️
pkg/yurthub/proxy/util/util.go 87.61% <0.00%> (+17.72%) ⬆️
pkg/yurthub/filter/servicetopology/handler.go 59.43% <0.00%> (+18.94%) ⬆️
pkg/util/ip/ip.go 40.54% <0.00%> (+19.11%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

rambohe-ch commented Aug 26, 2022

@fujitatomoya Thank you for posting pull request to replace beta.kubernetes.io labels. Frankly speaking, pull request #958 is also targeted to replace these labels, but #958 is not merged because the corresponding helm charts(yurt-tunnel-server and yurt-tunnel-agent) are not updated.

meanwhile, the owner of #958 have no response for nearly a week. so how about fix the helm charts instead of config/setup/yurt-tunnel-server.yaml for beta.kubernetes.io labels in your pull request?

@fujitatomoya
Copy link
Contributor Author

@rambohe-ch thanks for the quick response, will try that in this week.

@openyurt-bot openyurt-bot removed the size/XS size/XS: 0-9 label Aug 29, 2022
@fujitatomoya
Copy link
Contributor Author

@rambohe-ch see 2be849b

@openyurt-bot openyurt-bot added the size/S size/S 10-29 label Aug 29, 2022
@openyurt-bot openyurt-bot added the approved approved label Aug 30, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fujitatomoya, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/S size/S 10-29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants