-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add lantency metrics for yurthub #965
feature: add lantency metrics for yurthub #965
Conversation
@luc99hen: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #965 +/- ##
==========================================
+ Coverage 43.59% 44.42% +0.82%
==========================================
Files 83 83
Lines 11260 11370 +110
==========================================
+ Hits 4909 5051 +142
+ Misses 5914 5882 -32
Partials 437 437
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@luc99hen please fix codecov errors. |
ca1475d
to
09ef791
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luc99hen, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The latency collector is used to collect yurthub request latency metrics, and the latency metrics can be divided into two categories:
Special notes for your reviewer:
The full latency start recording after inflight requests limits has been applied, because latency of blocked requests is of no use.
Does this PR introduce a user-facing change?
other Note