Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add lantency metrics for yurthub #965

Merged

Conversation

luc99hen
Copy link
Member

@luc99hen luc99hen commented Aug 25, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

The latency collector is used to collect yurthub request latency metrics, and the latency metrics can be divided into two categories:

  • apiserver_latency: requests forward by proxy server -> api server -> received by proxy server
  • full_latency: requests comming to proxy server -> processing by proxy server -> api server -> received by proxy server -> proxy server handling

Special notes for your reviewer:

The full latency start recording after inflight requests limits has been applied, because latency of blocked requests is of no use.

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@luc99hen: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

The latency collector is used to collect yurthub request latency metrics, and the latency metrics can be divided into two categories:

  • apiserver_latency: requests forward by proxy server -> api server -> received by proxy server
  • full_latency: requests comming to proxy server -> processing by proxy server -> api server -> received by proxy server -> proxy server handling

Special notes for your reviewer:

The full latency start recording after inflight requests limits has been applied, because latency of blocked requests is of no use.

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added kind/feature kind/feature size/M size/M: 30-99 labels Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #965 (09ef791) into master (8896ea6) will increase coverage by 0.82%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #965      +/-   ##
==========================================
+ Coverage   43.59%   44.42%   +0.82%     
==========================================
  Files          83       83              
  Lines       11260    11370     +110     
==========================================
+ Hits         4909     5051     +142     
+ Misses       5914     5882      -32     
  Partials      437      437              
Flag Coverage Δ
unittests 44.42% <100.00%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurthub/proxy/util/util.go 87.61% <100.00%> (+17.72%) ⬆️
...troller/nodelifecycle/node_lifecycle_controller.go 56.15% <0.00%> (+0.60%) ⬆️
pkg/yurthub/filter/servicetopology/handler.go 59.43% <0.00%> (+18.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

@luc99hen please fix codecov errors.

@rambohe-ch rambohe-ch changed the title feature: add lantency metrics for yutrhub feature: add lantency metrics for yurthub Aug 26, 2022
@luc99hen luc99hen force-pushed the add-latency-collector-metrics branch from ca1475d to 09ef791 Compare August 29, 2022 07:27
@openyurt-bot openyurt-bot added size/L size/L: 100-499 and removed size/M size/M: 30-99 labels Aug 29, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luc99hen, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Aug 29, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@rambohe-ch rambohe-ch merged commit fd0d3d3 into openyurtio:master Aug 29, 2022
@luc99hen luc99hen deleted the add-latency-collector-metrics branch August 29, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants