-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate YurtHubHost & YurtHubProxyHost #959
Separate YurtHubHost & YurtHubProxyHost #959
Conversation
@luc99hen: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #959 +/- ##
==========================================
+ Coverage 39.73% 39.78% +0.04%
==========================================
Files 83 83
Lines 11247 11256 +9
==========================================
+ Hits 4469 4478 +9
Misses 6446 6446
Partials 332 332
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@luc99hen It's a good idea to separate YurtHubHost into YurtHubHost and YurtHubProxyHost. agree +1 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luc99hen, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Currently, yurthub only have one configurable host
YurtHubHost
for both yurthub server (metrics related API) & yurthub proxy server. The two servers served for different purposed have to share one host which is not resonable.This PR separate these two, and make them both configurable by adding a new flag
bind-proxy-address
toyurthub
cmdWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
This PR add a new cmd flag
bind-proxy-address
foryurthub
.other Note