Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate YurtHubHost & YurtHubProxyHost #959

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

luc99hen
Copy link
Member

@luc99hen luc99hen commented Aug 18, 2022

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Currently, yurthub only have one configurable host YurtHubHost for both yurthub server (metrics related API) & yurthub proxy server. The two servers served for different purposed have to share one host which is not resonable.

This PR separate these two, and make them both configurable by adding a new flag bind-proxy-address to yurthub cmd

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

This PR add a new cmd flag bind-proxy-address for yurthub.


other Note

@openyurt-bot
Copy link
Collaborator

@luc99hen: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Currently, yurthub only have one configurable host YurtHubHost for both yurthub server (metrics related API) & yurthub proxy server. The two servers served for different purposed have to share one host which is not resonable.

This PR separate these two, and make them both configurable by adding a new flag bind-proxy-address to yurthub cmd

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/M size/M: 30-99 label Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #959 (1ce3a71) into master (26465b0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
+ Coverage   39.73%   39.78%   +0.04%     
==========================================
  Files          83       83              
  Lines       11247    11256       +9     
==========================================
+ Hits         4469     4478       +9     
  Misses       6446     6446              
  Partials      332      332              
Flag Coverage Δ
unittests 39.78% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/ip/ip.go 40.54% <100.00%> (+19.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openyurt-bot openyurt-bot added the kind/enhancement kind/enhancement label Aug 18, 2022
@rambohe-ch
Copy link
Member

@luc99hen It's a good idea to separate YurtHubHost into YurtHubHost and YurtHubProxyHost. agree +1

@openyurt-bot openyurt-bot added the approved approved label Aug 19, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luc99hen, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch rambohe-ch merged commit 8c6ab2a into openyurtio:master Aug 19, 2022
@luc99hen luc99hen deleted the decouple_yurthub_server branch August 19, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants