Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yurtctl devfor ut #947

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Yurtctl devfor ut #947

merged 1 commit into from
Aug 19, 2022

Conversation

River-sh
Copy link
Contributor

@River-sh River-sh commented Aug 11, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Yurttest is the main function in yurtctl, and the unit test coverage of yurttest has been promoted to 56.1%.

other Note

@openyurt-bot
Copy link
Collaborator

@River-sh: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Yurttest is the main function in yurtctl, and the unit test coverage of yurttest has been promoted to 56.1%.

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

Welcome @River-sh! It looks like this is your first PR to openyurtio/openyurt 🎉

@openyurt-bot openyurt-bot added size/XL size/XL: 500-999 kind/enhancement kind/enhancement labels Aug 11, 2022
@rambohe-ch
Copy link
Member

@River-sh please fix the pipeline errors.

@openyurt-bot openyurt-bot added size/XXL and removed size/XL size/XL: 500-999 labels Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #947 (ee5eb95) into master (fac15a6) will increase coverage by 3.31%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #947      +/-   ##
==========================================
+ Coverage   40.28%   43.60%   +3.31%     
==========================================
  Files          80       83       +3     
  Lines       11003    11248     +245     
==========================================
+ Hits         4433     4905     +472     
+ Misses       6242     5908     -334     
- Partials      328      435     +107     
Flag Coverage Δ
unittests 43.60% <85.71%> (+3.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurtctl/cmd/yurttest/kindinit/init.go 50.60% <0.00%> (+41.11%) ⬆️
pkg/yurtctl/util/kubernetes/util.go 32.16% <82.60%> (+31.08%) ⬆️
pkg/yurtctl/cmd/yurttest/kindinit/converter.go 36.98% <100.00%> (+36.98%) ⬆️
pkg/yurtctl/cmd/yurttest/kindinit/kindoperator.go 50.73% <100.00%> (+20.36%) ⬆️
pkg/yurtctl/lock/lock.go 45.71% <100.00%> (+42.85%) ⬆️
pkg/yurtctl/util/kubernetes/apply_addons.go 14.61% <100.00%> (+14.61%) ⬆️
pkg/yurthub/server/server.go 0.00% <0.00%> (ø)
pkg/yurthub/server/nonresource.go 31.08% <0.00%> (ø)
pkg/yurthub/server/certificate.go 0.00% <0.00%> (ø)
pkg/yurthub/cachemanager/cache_manager.go 68.22% <0.00%> (+0.07%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@openyurt-bot openyurt-bot added size/XL size/XL: 500-999 size/XXL and removed size/XXL size/XL size/XL: 500-999 labels Aug 15, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, River-sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Aug 19, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@rambohe-ch rambohe-ch merged commit e2d4277 into openyurtio:master Aug 19, 2022
@rambohe-ch
Copy link
Member

Fixes #920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants