bump ginkgo to v2 #945
bump ginkgo to v2 #945
Conversation
openyurt-bot
added
the
do-not-merge/work-in-progress
|
@lorrielau: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #945 +/- ##
==========================================
+ Coverage 43.59% 43.65% +0.05%
==========================================
Files 83 83
Lines 11260 11260
==========================================
+ Hits 4909 4915 +6
+ Misses 5914 5909 -5
+ Partials 437 436 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pkg/util/kubernetes/kubeadm/app/util/initsystem/initsystem_unix.go
Outdated
Show resolved
Hide resolved
| @@ -1,3 +1,4 @@ | |||
| //go:build !windows | |||
| @@ -1,3 +1,4 @@ | |||
| //go:build !windows | |||
test/e2e/yurt/yurt.go
Outdated
| _, err = ns.CreateNameSpace(c, YurtE2ENamespaceName) | ||
| gomega.Expect(err).NotTo(gomega.HaveOccurred(), "fail to create namespace") | ||
|
|
||
| util.YurtDescribe(YurtE2ETestDesc+"yurt_test_create namespace", func() { |
There was a problem hiding this comment.
Should it be BeforeEach rather than Describe?
We need to create pod in this namespace later in test pod_operate.
There was a problem hiding this comment.
It makes us depend on that yurt_test_create namespace should run before the pod_operate. It is not always the case.
|
@Congrool Please take a look. Sorry for the late feedback. I've deleted the ginkgo.by part in e2e-yurt-create-namespace. |
test/e2e/e2e.go
Outdated
| klog.Infof("Starting e2e run %q on Ginkgo node %d", uuid.NewUUID(), types.NewDefaultSuiteConfig().ParallelProcess) | ||
| //klog.Infof("Starting e2e run %q on Ginkgo node %d", uuid.NewUUID(), config.GinkgoConfig.ParallelNode) | ||
| ginkgo.RunSpecs(t, "openyurt e2e suite") | ||
| //ginkgo.RunSpecsWithDefaultAndCustomReporters(t, "openyurt e2e suite", r) |
test/e2e/e2e.go
Outdated
| if yurtconfig.YurtE2eCfg.ReportDir != "" { | ||
| if err := os.MkdirAll(yurtconfig.YurtE2eCfg.ReportDir, 0755); err != nil { | ||
| klog.Errorf("Failed creating report directory: %v", err) | ||
| } else { | ||
| r = append(r, reporters.NewJUnitReporter(path.Join(yurtconfig.YurtE2eCfg.ReportDir, fmt.Sprintf("yurt-e2e-test-report_%02d.xml", config.GinkgoConfig.ParallelNode)))) | ||
| reporters.GenerateJUnitReport(r, path.Join(yurtconfig.YurtE2eCfg.ReportDir, fmt.Sprintf("yurt-e2e-test-report_%02d.xml", types.NewDefaultSuiteConfig().ParallelProcess))) |
There was a problem hiding this comment.
Check the err returned by reporters.GenerateJUnitReport.
|
Please rebase and squash your commits. |
lorrielau
force-pushed
the
master
branch
2 times, most recently
from
51bf367 to
22ebfb4
Compare
openyurt-bot
removed
the
do-not-merge/work-in-progress
lorrielau
force-pushed
the
master
branch
3 times, most recently
from
a0f76a0 to
8cea11a
Compare
|
/lgtm |
|
@Congrool: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lorrielau, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Bump ginkgo to v2.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
@Congrool
Does this PR introduce a user-facing change?
other Note