Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decouple yurtctl with yurtadm #848

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

Congrool
Copy link
Member

Signed-off-by: Congrool [email protected]

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Decouple yurtctl with yurtadm. Before this pr, code in pkg/yurtctl imported package in pkg/yurtadm, which makes code confused for read and difficult to maintain. This pr totaly separates yurtctl from yurtadm.

The following work was done in this pr:

  1. move pkg/yurtadm/kubernetes to pkg/util/kubernetes for general use
  2. move pkg/yurtadm/util/templates and pkg/yurtadm/util/strings to pkg/util/templates and pkg/util/strings respectively for general use
  3. move constants which are only used by yurtctl from pkg/yurtadm to pkg/yurtctl
  4. move functions that only used by yurtctl from pkg/yurtadm/util/kubernetes to pkg/yurtctl/util/kubernetes

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @rambohe-ch @lonelyCZ

Does this PR introduce a user-facing change?


other Note

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label May 27, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Congrool, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label May 27, 2022
@rambohe-ch rambohe-ch merged commit 65451d3 into openyurtio:master May 27, 2022
@Congrool Congrool deleted the decouple branch May 27, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants