-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancemnt] support local up openyurt on mac machine #836
Conversation
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @Congrool @donychen1134 |
@rambohe-ch: GitHub didn't allow me to assign the following users: donychen1134. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
678ada9
to
f10c4dd
Compare
review seems to need a little time to finish. I'll continue to review in the coming few days |
6d4f5fb
to
00a9df2
Compare
00a9df2
to
242726d
Compare
@Congrool All of comments have been fixed, please take a look. |
242726d
to
936a0bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other revise is at Congrool@e7bbb91, including
- enable REGION, when set as cn, the GOPROXY and apk repository source will be set as a mirror in China.
- decouple local-up-openyurt with docker-build, we don't need to always build the image before local-up-openyurt
- change the image-tag. For HEAD which is actually points at a tag, like v0.6.0, the image tag will be v0.6.0, otherwise the image tag will be v0.6.0-${commit}. Use this image tag, we can avoid overwriting the image which already has the tag v0.6.0 when building images.
The commit was updated for fixing github action error.
936a0bc
to
cccb862
Compare
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Congrool, DrmagicE, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
In order to make OpenYurt developer can debug easily, In this pull request, we support to startup OpenYurt cluster locally on mac env. and the enhancements are as following:
docker buildx build
to build OpenYurt Components images that can run across multi platforms.node-servant config control-plane
command for configuring kube-apiserver and kube-controller-manager static pod.--enable-dummy-if
and--enable-node-pool
parameter fornode-servant convert
command in order to disable dummy interface and node pool list/watch for yurthub in mac envConfigureAddons
process for setting coredns and kube-proxy pod.Which issue(s) this PR fixes:
Fixes #811
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note