Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] fix mistaken selflink in yurthub #785

Merged
merged 1 commit into from
Mar 21, 2022
Merged

[bugfix] fix mistaken selflink in yurthub #785

merged 1 commit into from
Mar 21, 2022

Conversation

Congrool
Copy link
Member

@Congrool Congrool commented Mar 21, 2022 •
edited
Loading

What type of PR is this?

/kind bug

SelfLink should have the format /<apigroup>/<apiversion>/<resource>.

By the way, selflink will be removed soon at KEP, and we may have to take it into consideration. The timeline is:

2019-07-23: KEP merged.
2019-07-24: KEP move to implementable.
v1.16: Released in Alpha
v1.20: Released in Beta, enabled by default
2022-01-10: KEP updated to target GA in v1.24

@openyurt-bot openyurt-bot added the kind/bug kind/bug label Mar 21, 2022
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Mar 21, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Mar 21, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Congrool, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Mar 21, 2022
@openyurt-bot openyurt-bot merged commit 3300bf1 into openyurtio:master Mar 21, 2022
@Congrool Congrool deleted the selflink branch March 21, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambohe-ch rambohe-ch rambohe-ch approved these changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

@huangyuqi huangyuqi Awaiting requested review from huangyuqi

Assignees

@rambohe-ch rambohe-ch

Labels
approved approved kind/bug kind/bug lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Congrool @rambohe-ch @openyurt-bot