-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add yurtctl test init
cmd to setup OpenYurt cluster with kind
#783
Conversation
@Congrool: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This pr only enables |
/assign @Peeknut |
@Congrool Because usage of yurtctl init is changed, so how about to update user manual document of |
OK, I'll update it. |
lgtm But we want yurtctl init to just initialize the master node and yurtctl join to join the nodes. After the change, |
@Peeknut It's a good question, and i agree with that |
🤔 How adout adding a new command called |
agree |
@Congrool agree +1, add a new command |
/hold |
yurtctl test init
cmd to setup OpenYurt cluster with kind
/unhold |
@Congrool How about modify e2e test in github action to use |
Sure, I'll revise the github action. |
cb8f93f
to
0884ee5
Compare
Signed-off-by: Congrool <[email protected]> Signed-off-by: Congrool <[email protected]>
/unhold |
Signed-off-by: Congrool <[email protected]> Signed-off-by: Congrool <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Congrool, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
1 similar comment
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
As mentioned is #736, we will deprecate
yurtctl convert/revert
which is used by github actions. To run e2e tests in github actions, we still need a way to setup OpenYurt cluster with kind. It is this pr.Which issue(s) this PR fixes:
Fixes #754
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Currently, the yurtctl test looks like as follows:
So, that developers can setup openyurt cluster with cmd
yurtctl test init
.CHANGLOG-2022.4.9
Revise the local_up_openyurt.sh to use
yurtctl test init
to setup OpenYurt cluster.