-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement] enable yurthub to handle upgrade request #673
Conversation
I've rerun the failed conformance cases in #562, and all cases passed. Here's also some websocket request logs. WSAPISERVER=wss://169.254.2.1:10268
SECRET_NAME=log-exporter-sa-token-jkqlt
TOKEN=$(kubectl get secret $SECRET_NAME -o jsonpath='{.data.token}' | base64 --decode)
wscat -n -c $WSAPISERVER/api/v1/namespaces/kube-system/pods/yurt-tunnel-agent-cssqz/log?container=yurt-tunnel-agent --header "Authorization: Bearer $TOKEN" We can see that the proxy of websocket request succeeded. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Congrool, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Congrool Based on this pull request, |
/hold |
@rambohe-ch As mentioned in the #562, the problem has been solved by #560. |
/hold cancel |
@DrmagicE Do you have any comments about this pull request? |
/lgtm |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Since APIServer can handle websocket request, yurthub which is serving as a proxy server for kubelet and other components should have the capability of proxying websocket traffic to APIServer.
Which issue(s) this PR fixes:
Fixes #562
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note