Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate kubelet certificate management mode #639

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

qclc
Copy link
Member

@qclc qclc commented Nov 30, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage
/kind design

What this PR does / why we need it:

  1. Deprecate kubelet certificate management mode (Yurthub shares certificates with Kubelet)
  2. Delete the relevant code for sharing the certificate with kubelet

Which issue(s) this PR fixes:

Fixes #573

Special notes for your reviewer:

@rambohe-ch please take review

Does this PR introduce a user-facing change?

After this code is merged, if the --cert-mgr-mode flag of yurthub is set to kubelet , yurthub will report an error message: validate options: cert manage mode kubelet is not supported, and exit.

other Note

@openyurt-bot
Copy link
Collaborator

@qclc: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage
/kind design

What this PR does / why we need it:

  1. Deprecate kubelet certificate management mode (Yurthub shares certificates with Kubelet)
  2. Delete the relevant code for sharing the certificate with kubelet

Which issue(s) this PR fixes:

Fixes #573

Special notes for your reviewer:

@rambohe-ch please take review

Does this PR introduce a user-facing change?

After this code is merged, if the --cert-mgr-mode flag of yurthub is set to kubelet , yurthub will report an error message: validate options: cert manage mode kubelet is not supported, and exit.

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/design kind/design label Nov 30, 2021
@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Nov 30, 2021
@openyurt-bot openyurt-bot added the approved approved label Nov 30, 2021
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qclc, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit 5a71e9e into openyurtio:master Nov 30, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/design kind/design lgtm lgtm size/L size/L: 100-499
Projects
None yet
3 participants