Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use const instead the string #614

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

pengbinbin1
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

I think const is better than a string

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

-->


other Note

@openyurt-bot
Copy link
Collaborator

@pengbinbin1: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

I think const is better than a string

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

-->


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

Welcome @pengbinbin1! It looks like this is your first PR to openyurtio/openyurt 🎉

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Nov 22, 2021
@pengbinbin1
Copy link
Member Author

/assign @rambohe-ch

@rambohe-ch
Copy link
Member

@pengbinbin1 Thank you for raising pull request. I think it's not reasonable to add envs into yurt-hub-cfg configmap, because yurt-hub-cfg configmap is used by yurthub component, not by yurtctl tool.

@adamzhoul Do you have any comments about this pull request?

@pengbinbin1
Copy link
Member Author

@pengbinbin1: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

@pengbinbin1 Thank you for raising pull request. I think it's not reasonable to add envs into yurt-hub-cfg configmap, because yurt-hub-cfg configmap is used by yurthub component, not by yurtctl tool.

@adamzhoul Do you have any comments about this pull request?

OK , i have moved the envs into the util.go

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pengbinbin1, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Nov 22, 2021
@rambohe-ch
Copy link
Member

OK , i have moved the envs into the util.go

@pengbinbin1 It sounds good to move envs definition in util.go.

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Nov 22, 2021
@openyurt-bot openyurt-bot merged commit f1a5a78 into openyurtio:master Nov 22, 2021
@pengbinbin1 pengbinbin1 deleted the dev branch November 26, 2021 08:27
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants