-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use const instead the string #614
Conversation
@pengbinbin1: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @pengbinbin1! It looks like this is your first PR to openyurtio/openyurt 🎉 |
/assign @rambohe-ch |
@pengbinbin1 Thank you for raising pull request. I think it's not reasonable to add envs into @adamzhoul Do you have any comments about this pull request? |
OK , i have moved the envs into the util.go |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pengbinbin1, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pengbinbin1 It sounds good to move envs definition in util.go. |
/lgtm |
What type of PR is this?
What this PR does / why we need it:
I think const is better than a string
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
-->
other Note