Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject working_mode #552

Merged
merged 1 commit into from
Nov 3, 2021
Merged

inject working_mode #552

merged 1 commit into from
Nov 3, 2021

Conversation

ngau66
Copy link
Contributor

@ngau66 ngau66 commented Nov 2, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug

What this PR does / why we need it:

yurtctl join --node-type=edge-node doesn't work because the working_mode variable is missing.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @huangyuqi

@openyurt-bot
Copy link
Collaborator

@ngau66: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubectl join edge node does not work because the working_mode variable is missing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

Welcome @ngau66! It looks like this is your first PR to openyurtio/openyurt 🎉

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Nov 2, 2021
@rambohe-ch
Copy link
Member

/assign @zyjhtangtang

@zyjhtangtang
Copy link
Contributor

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Nov 3, 2021
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ngau66, zyjhtangtang
To complete the pull request process, please assign huangyuqi
You can assign the PR to them by writing /assign @huangyuqi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Fei-Guo
Copy link
Member

Fei-Guo commented Nov 3, 2021

/lgtm
/approve

@Fei-Guo Fei-Guo merged commit 7413f76 into openyurtio:master Nov 3, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants