Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve the usage of certificates #475

Merged
merged 1 commit into from Sep 17, 2021
Merged

perf: improve the usage of certificates #475

merged 1 commit into from Sep 17, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 16, 2021

What type of PR is this?

/kind enhancement
/kind good-first-issue
/kind feature

What this PR does / why we need it:

We need to specify the usage of certificates of yurt-tunnel components clearly.

Which issue(s) this PR fixes:

Fixes #410

@openyurt-bot openyurt-bot added the size/S size/S 10-29 label Sep 16, 2021
@rambohe-ch
Copy link
Member

rambohe-ch commented Sep 16, 2021

@ke-jobs Thank you for improving certificate usage of yurt-tunnel. please fix the golangci-lint error of github actions. you can click the Details link to look up the detailed errors.

@ghost
Copy link
Author

ghost commented Sep 16, 2021

thanks, I have fixed it

@openyurt-bot openyurt-bot added size/M size/M: 30-99 and removed size/S size/S 10-29 labels Sep 16, 2021
we need to specify the usage of certificates of yurt-tunnel components clearly.

Refs #410
@rambohe-ch
Copy link
Member

@ke-jobs Would you like to apply OpenYurt community member? you can add me as sponsor, and here is an example: openyurtio/community#25

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ke-jobs, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Sep 17, 2021
@openyurt-bot openyurt-bot merged commit 427972f into openyurtio:master Sep 17, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
we need to specify the usage of certificates of yurt-tunnel components clearly.

Refs openyurtio#410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[yurt-tunnel]improve the usage of certificates
2 participants