-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: prepare yurthub server tls config panic #457
bugfix: prepare yurthub server tls config panic #457
Conversation
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/approve |
/lgtm |
@zc2638 Thanks for testing. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
if yurthub re-startup when network between cloud and edge disconnected, a panic will happen for preparing server tls config. and the panic like as following:
reason:
yurthub will use healthy server address and certificate under
/var/lib/yurthub/pki
dir to createrest.Config
for https server. the code is here: https://github.com/openyurtio/openyurt/blob/master/pkg/yurthub/kubernetes/rest/config.go#L83-113and when cloud-edge network breaks down, healthy server will become true, so
rest.Config
will be nil, then panic happened.solution:
we only need to prepare for
rest.Config
, and not need to connect remote server, so healthy server is not a requirement, so we add aneedHealthyServer
parameter forGetRestConfig()
to createrest.Config
whether healthy server should be set or not.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note