Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support forward cloud requests to edge node's localhost endpoint #443

Merged

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind feature

What this PR does / why we need it:

  1. when components(like prometheus) on cloud nodes usually use NodeIP:Port to collect component(like yurthub) metrics on edge node, but edge components listen on 127.0.0.1:Port instead of NodeIP:Port for security consideration. so we need to add this feature to support proxy cloud requests to localhost endpoint of edge nodes.
  2. The way of enable this feature:
    • user can configure the yurt-tunnel-server-cfg configmap, and add specified tcp ports in localhost-proxy-ports field of configmap.
  3. for example: yurthub listens on http://127.0.0.1:10267/metrics and yurt-tunnel-agent listens on http://127.0.0.1:10266, user need to configure yurt-tunnel-server-cfg configmap fields as following:
localhost-proxy-ports: "10266, 10267"

Which issue(s) this PR fixes:

Fixes #415

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind feature

What this PR does / why we need it:

  1. when components(like prometheus) on cloud nodes usually use NodeIP:Port to collect component(like yurthub) metrics on edge node, but edge components listen on 127.0.0.1:Port instead of NodeIP:Port for security consideration. so we need to add this feature to support proxy cloud requests to localhost endpoint of edge nodes.
  2. The way of enable this feature:
    • user can configure the yurt-tunnel-server-cfg configmap, and add specified tcp ports in localhost-proxy-ports field of configmap.
  3. for example: yurthub listens on http://127.0.0.1:10267/metrics and yurt-tunnel-agent listens on http://127.0.0.1:10266, user need to configure yurt-tunnel-server-cfg configmap fields as following:
localhost-proxy-ports: "10266, 10267"

Which issue(s) this PR fixes:

Fixes #415

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Aug 31, 2021
@openyurt-bot openyurt-bot added approved approved size/L size/L: 100-499 labels Aug 31, 2021
@rambohe-ch
Copy link
Member Author

/assign @SataQiu @Fei-Guo

@Fei-Guo
Copy link
Member

Fei-Guo commented Aug 31, 2021

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Aug 31, 2021
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fei-Guo, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit 97a1a21 into openyurtio:master Aug 31, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[yurt tunnel]support proxy nodeIP:port request to access 127.0.0.1 address on the edge
4 participants