Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix for autonomous #441

Merged
merged 3 commits into from
Aug 31, 2021
Merged

bug fix for autonomous #441

merged 3 commits into from
Aug 31, 2021

Conversation

JameKeal
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

I made a mistake for auto open the autonomous, the node status is not latest to add a annotations.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

JameKeal and others added 3 commits August 26, 2021 15:40
@JameKeal
auto open the autonomous when convert edgenode
84df2f8
@JameKeal
Update edgenode.go
3b1d59c 
fix the bug: Operate node but node is not latest.
@JameKeal
Merge pull request #1 from JameKeal/JameKeal-patch-1
b4100e2 
fix the bug: Operate node but node is not latest
@openyurt-bot
Copy link
Collaborator

@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

I made a mistake for auto open the autonomous, the node status is not latest to add a annotations.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/bug kind/bug label Aug 31, 2021
@openyurt-bot openyurt-bot added the size/S size/S 10-29 label Aug 31, 2021
@rambohe-ch
Copy link
Member

@JameKeal Thank you for fixing autonomy setting.

@rambohe-ch
Copy link
Member

/lgtm
/approve

1 similar comment
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Aug 31, 2021
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JameKeal, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Aug 31, 2021
@openyurt-bot openyurt-bot merged commit 55ca955 into openyurtio:master Aug 31, 2021
@JameKeal JameKeal deleted the jameKeal-pr2 branch November 6, 2021 02:20
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
@JameKeal
bug fix for autonomous (openyurtio#441)
fde7a7a 
* auto open the autonomous when convert edgenode

* Update edgenode.go

fix the bug: Operate node but node is not latest.
@JameKeal JameKeal mentioned this pull request Apr 19, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huangyuqi huangyuqi Awaiting requested review from huangyuqi

@kadisi kadisi Awaiting requested review from kadisi

Assignees

@rambohe-ch rambohe-ch

Labels
approved approved kind/bug kind/bug lgtm lgtm size/S size/S 10-29
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JameKeal @openyurt-bot @rambohe-ch