Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yurtcluster operator proposal #429

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Update yurtcluster operator proposal #429

merged 1 commit into from
Sep 10, 2021

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Aug 18, 2021

What type of PR is this?

/kind design

What this PR does / why we need it:

Update yurtcluster operator proposal

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

other Note

@openyurt-bot openyurt-bot added kind/design kind/design size/L size/L: 100-499 labels Aug 18, 2021
@SataQiu
Copy link
Member Author

SataQiu commented Aug 18, 2021

/cc @rambohe-ch @gnunu

@SataQiu SataQiu force-pushed the update-operator-proposal branch from 0d17613 to 20c548d Compare September 6, 2021 05:43
@SataQiu
Copy link
Member Author

SataQiu commented Sep 7, 2021

/assign @Fei-Guo
PTAL!

Fei-Guo
Fei-Guo reviewed Sep 7, 2021
View reviewed changes
Copy link
Member

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM. Sorry for the delay.

docs/proposals/20210722-yurtcluster-operator.md Outdated Show resolved Hide resolved
docs/proposals/20210722-yurtcluster-operator.md Outdated Show resolved Hide resolved
@SataQiu SataQiu force-pushed the update-operator-proposal branch from 20c548d to 5082161 Compare September 10, 2021 02:41
@SataQiu
Copy link
Member Author

SataQiu commented Sep 10, 2021

Thanks @Fei-Guo @rambohe-ch !
All suggestions have been addressed.

@Fei-Guo
Copy link
Member

Fei-Guo commented Sep 10, 2021

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Sep 10, 2021
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fei-Guo, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Sep 10, 2021
@openyurt-bot openyurt-bot merged commit b64a2b0 into openyurtio:master Sep 10, 2021
@SataQiu SataQiu mentioned this pull request Sep 13, 2021
Merged
6 tasks
@SataQiu SataQiu mentioned this pull request Nov 15, 2021
Merged
6 tasks
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
@SataQiu
update yurtcluster operator proposal (openyurtio#429)
9c87226 
Signed-off-by: SataQiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambohe-ch rambohe-ch rambohe-ch left review comments

@Fei-Guo Fei-Guo Fei-Guo left review comments

@gnunu gnunu Awaiting requested review from gnunu

@charleszheng44 charleszheng44 Awaiting requested review from charleszheng44

@kadisi kadisi Awaiting requested review from kadisi

Assignees

@Fei-Guo Fei-Guo

Labels
approved approved kind/design kind/design lgtm lgtm size/L size/L: 100-499
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SataQiu @Fei-Guo @openyurt-bot @rambohe-ch