Add sync.Pool to cache *bufio.Reader in tunnel server #381
Conversation
|
@DrmagicE: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @huangyuqi |
| ) | ||
|
|
||
| func newBufioReader(r io.Reader) *bufio.Reader { |
There was a problem hiding this comment.
please add comments for newBufioReader func.
| return bufio.NewReader(r) | ||
| } | ||
|
|
||
| func putBufioReader(br *bufio.Reader) { |
There was a problem hiding this comment.
please add comments for putBufioReader func.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DrmagicE, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
* add sync.Pool to cache *bufio.Reader in tunnel server * Docs: update supported kubernetes version to 1.18 * add comments
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Use
sync.Poolto reduce memory allocation and avoid GC pressure.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note