Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal to add subcommands init, join, reset for yurtctl. #341

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

zyjhtangtang
Copy link
Contributor

@zyjhtangtang zyjhtangtang commented Jun 7, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind design

What this PR does / why we need it:

This proposal add three subcommands init, join and reset for yurtctl. The subcommand init can create an all-in-one kubernetes cluster, simultaneously convert the kuberntes cluster to an OpenYurt cluster. The subcommand join is used to add a new node to an OpenYurt cluster, including cloud nodes and edge nodes. The subcommand reset can restore the node to the state before joining OpenYurt cluster.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @rambohe-ch @huangyuqi

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@zyjhtangtang: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind design

What this PR does / why we need it:

This proposal add three subcommands server, join and reset for yurtctl. The subcommand server can create an all-in-one kubernetes cluster, simultaneously convert the kuberntes cluster to an OpenYurt cluster. The subcommand join is used to add a new node to an OpenYurt cluster, including cloud nodes and edge nodes. The subcommand reset can restore the node to the state before joining OpenYurt cluster.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @rambohe-ch @huangyuqi

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/design kind/design label Jun 7, 2021
@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Jun 7, 2021
@zyjhtangtang zyjhtangtang force-pushed the master branch 4 times, most recently from f32203f to eb34666 Compare June 9, 2021 03:13
Refer to the [OpenYurt Glossary](https://github.com/openyurtio/openyurt/blob/master/docs/proposals/00_openyurt-glossary.md).

## Summary
This proposal add three subcommands `server`, `join` and `reset` for yurtctl. The subcommand `server` can create an all-in-one kubernetes cluster, simultaneously convert the kuberntes cluster to an OpenYurt cluster. The subcommand `join` is used to add a new node to an OpenYurt cluster, including cloud nodes and edge nodes. The subcommand `reset` can restore the node to the state before joining OpenYurt cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about rename the subcommand server to init, so the experience of yurtctl will be consistent with Kubeadm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I have renamed the subcommand server to init.

@yanyhui
Copy link
Member

yanyhui commented Jun 13, 2021

I think the 'join' subcommand should support multiple scenarios:

First, join node after executing 'server' subcommand;

Second, after the yurtctl convert to openyurt is executed on the original k8s cluster, the 'join' subcommand can be executed to access the new node;

Third, on the basis of the original k8s cluster, after manually installing openyurt, you can execute the 'join' subcommand to access the new node.

@zyjhtangtang zyjhtangtang changed the title proposal to add subcommands server, join, reset for yurtctl. proposal to add subcommands init, join, reset for yurtctl. Jun 16, 2021
@zyjhtangtang zyjhtangtang requested a review from rambohe-ch June 16, 2021 06:24
@zyjhtangtang zyjhtangtang force-pushed the master branch 6 times, most recently from 6fd6d3b to fbd975b Compare June 16, 2021 06:53
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Jul 1, 2021
@rambohe-ch
Copy link
Member

/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, zyjhtangtang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jul 1, 2021
@openyurt-bot openyurt-bot merged commit aebc859 into openyurtio:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/design kind/design lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants