-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal to add subcommands init, join, reset for yurtctl. #341
Conversation
@zyjhtangtang: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f32203f
to
eb34666
Compare
Refer to the [OpenYurt Glossary](https://github.com/openyurtio/openyurt/blob/master/docs/proposals/00_openyurt-glossary.md). | ||
|
||
## Summary | ||
This proposal add three subcommands `server`, `join` and `reset` for yurtctl. The subcommand `server` can create an all-in-one kubernetes cluster, simultaneously convert the kuberntes cluster to an OpenYurt cluster. The subcommand `join` is used to add a new node to an OpenYurt cluster, including cloud nodes and edge nodes. The subcommand `reset` can restore the node to the state before joining OpenYurt cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about rename the subcommand server
to init
, so the experience of yurtctl will be consistent with Kubeadm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I have renamed the subcommand server to init.
I think the 'join' subcommand should support multiple scenarios: First, join node after executing 'server' subcommand; Second, after the yurtctl convert to openyurt is executed on the original k8s cluster, the 'join' subcommand can be executed to access the new node; Third, on the basis of the original k8s cluster, after manually installing openyurt, you can execute the 'join' subcommand to access the new node. |
6fd6d3b
to
fbd975b
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, zyjhtangtang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind design
What this PR does / why we need it:
This proposal add three subcommands
init
,join
andreset
for yurtctl. The subcommandinit
can create an all-in-one kubernetes cluster, simultaneously convert the kuberntes cluster to an OpenYurt cluster. The subcommandjoin
is used to add a new node to an OpenYurt cluster, including cloud nodes and edge nodes. The subcommandreset
can restore the node to the state before joining OpenYurt cluster.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/assign @rambohe-ch @huangyuqi
Does this PR introduce a user-facing change?
other Note