[feature]: add dummy network interface for yurthub #289
Conversation
rambohe-ch
force-pushed
the
add-dummy-interface
branch
2 times, most recently
from
449ec78 to
e1466a6
Compare
|
lgtm |
|
Just have a question, on the edge node, except kubelet, which component will need to access yurthub? |
any components(like kubelet, kube-proxy, flannel and so on) that want to use yurthub cache when cloud-edge network disconnected. |
| type unsupportedInterfaceController struct { | ||
| } | ||
|
|
||
| func NewDummyInterfaceController() DummyInterfaceController { |
There was a problem hiding this comment.
Should NewDummyInterfaceController be NewUnsupportedDummyInterfaceController?
Where is the unsupportedDummyController used?
There was a problem hiding this comment.
when os is not linux, unsupportedDummyController will be used by NetworkManager, and when os is linux, dummyif_linux.go will be used.
|
|
||
| klog.Infof("ip address for %s interface changed to %s", ifName, ifIP.String()) | ||
| return dic.AddrReplace(link, &netlink.Addr{IPNet: netlink.NewIPNet(ifIP)}) | ||
| } |
There was a problem hiding this comment.
if err != nil, why not returning err but calling addDummyInterface? Maybe a comment is needed.
There was a problem hiding this comment.
yeah, add error handle here, if err is Link not found , we will call addDummyInterface, otherwise return err.
cmd/yurthub/app/start.go
Outdated
| networkMgr.Run(stopCh) | ||
| trace++ | ||
|
|
||
| klog.Infof("%d. new %s server and begin to serve, proxy server: %s;%s, hub server: %s", trace, |
There was a problem hiding this comment.
You should add "dummy proxy server" before "%s" in the log line.
cmd/yurthub/app/start.go
Outdated
| @@ -157,10 +158,28 @@ func Run(cfg *config.YurtHubConfiguration, stopCh <-chan struct{}) error { | |||
| } | |||
| trace++ | |||
|
|
|||
| klog.Infof("%d. new %s server and begin to serve, proxy server: %s, hub server: %s", trace, projectinfo.GetHubName(), cfg.YurtHubProxyServerAddr, cfg.YurtHubServerAddr) | |||
| s := server.NewYurtHubServer(cfg, certManager, yurtProxyHandler) | |||
| klog.Infof("%d. create dummy network interface %s and init iptables manager", trace, cfg.HubAgentDummyIfName) | |||
There was a problem hiding this comment.
I think the entire change in this file should be guarded by "if cfg.EnableDummyIf ". This change should introduce zero overhead if people does not need/disable this feature.
rambohe-ch
force-pushed
the
add-dummy-interface
branch
from
e1466a6 to
da97b02
Compare
|
@rambohe-ch hello rambohe, I'd like to consult you about.. What does iptable do in your commit file |
Ⅰ. Describe what this PR does
background:
Yurthub is a node daemon that serves as a proxy for the outbound traffic from the Kubernetes node daemons(like kubelet, kube-proxy and so on), and yurthub is listening on
127.0.0.1:10261for proxying outbound traffic. so components with hostNetwork=false can not use yurthub to proxy outbound request because of traffic fromcontainer network namespaceto127.0.0.1can not route on edge node.solution:
Add a dummy network interface on edge node by yurthub, and yurthub listens on
new dummy interface, so components in its own network namespace can access yurthub through dummy interface.the default ip address of new dummy interface is:
169.254.2.1, the interface name is:yurthub-dummy0usage for components on edge node:
to access kube-apiserver through yurthub for components, at first make sure that components can support to set yurthub address instead of kube-apiserver address. and the address of yurthub as following:
Ⅱ. Does this pull request fix one issue?
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
make all
and make sure yurthub can work correctly.
Ⅴ. Special notes for reviews