Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix t.Fatalf from a non-test goroutine #269

Merged
merged 1 commit into from
Apr 20, 2021
Merged

fix t.Fatalf from a non-test goroutine #269

merged 1 commit into from
Apr 20, 2021

Conversation

contrun
Copy link
Contributor

@contrun contrun commented Apr 20, 2021

Fixes #248.

SataQiu
SataQiu reviewed Apr 20, 2021
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@rambohe-ch

rambohe-ch
rambohe-ch approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@rambohe-ch rambohe-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rambohe-ch rambohe-ch merged commit 5374af4 into openyurtio:master Apr 20, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
@rambohe-ch
Merge pull request openyurtio#269 from contrun/fix-goroutine-fatalf
9aa0407 
fix t.Fatalf from a non-test goroutine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SataQiu SataQiu SataQiu left review comments

@rambohe-ch rambohe-ch rambohe-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkg/yurthub/util/util_test.go:37:4: call to (*T).Fatalf from a non-test goroutine
3 participants
@contrun @SataQiu @rambohe-ch