Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] yurtctl cluster-info subcommand that list edge/cloud nodes #208

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

neo502721
Copy link
Member

Ⅰ. Describe what this PR does

Add a yurtctl subcommand cluster-info, that list edge and cloud nodes

Ⅱ. Does this pull request fix one issue?

fixes #207

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

  1. make build
  2. ./_output/bin/yurtctl cluster-info

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2021

CLA assistant check
All committers have signed the CLA.

pkg/yurtctl/cmd/clusterinfo/clusterinfo.go Outdated Show resolved Hide resolved
pkg/yurtctl/cmd/clusterinfo/clusterinfo.go Outdated Show resolved Hide resolved
pkg/yurtctl/cmd/clusterinfo/clusterinfo.go Show resolved Hide resolved
pkg/yurtctl/cmd/clusterinfo/clusterinfo.go Outdated Show resolved Hide resolved
pkg/yurtctl/cmd/clusterinfo/clusterinfo.go Show resolved Hide resolved
@neo502721
Copy link
Member Author

Code has been updated based on review comments by @rambohe-ch

@neo502721 neo502721 force-pushed the master branch 3 times, most recently from f15add7 to 82f4595 Compare January 28, 2021 05:01
@rambohe-ch
Copy link
Member

Code has been updated based on review comments by @rambohe-ch

@neo502721 thank you for your quick response, and i add a new comment as above

@rambohe-ch
Copy link
Member

@neo502721 please merge two commits into one commit, so we will trace this feature easily.

@neo502721
Copy link
Member Author

neo502721 commented Jan 29, 2021

@neo502721 please merge two commits into one commit, so we will trace this feature easily.

OK, the change has been completed. @rambohe-ch

@rambohe-ch
Copy link
Member

LGTM

@rambohe-ch rambohe-ch merged commit 0ac07d6 into openyurtio:master Feb 3, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
[feature request] yurtctl cluster-info subcommand that list edge/cloud nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] yurtctl cluster-info subcommand that list edge/cloud nodes
3 participants