Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intercept kubelet get node request in order to reduce the traffic #2039

Merged
merged 7 commits into from
May 23, 2024

Conversation

vie-serendipity
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

other Note

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 34.61538% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 55.56%. Comparing base (37addb5) to head (a8cc010).
Report is 5 commits behind head on master.

Files Patch % Lines
pkg/yurthub/cachemanager/cache_manager.go 44.44% 8 Missing and 2 partials ⚠️
pkg/yurthub/proxy/util/util.go 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2039      +/-   ##
==========================================
+ Coverage   55.37%   55.56%   +0.18%     
==========================================
  Files         185      186       +1     
  Lines       17821    18079     +258     
==========================================
+ Hits         9869    10046     +177     
- Misses       6934     7009      +75     
- Partials     1018     1024       +6     
Flag Coverage Δ
unittests 55.56% <34.61%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vie-serendipity
Copy link
Member Author

/rerun

4 similar comments
@vie-serendipity
Copy link
Member Author

/rerun

@vie-serendipity
Copy link
Member Author

/rerun

@vie-serendipity
Copy link
Member Author

/rerun

@vie-serendipity
Copy link
Member Author

/rerun

@vie-serendipity vie-serendipity force-pushed the feat/intercept-kubelet branch from 8b1e3b5 to 18b6383 Compare May 8, 2024 07:04
@vie-serendipity
Copy link
Member Author

/rerun

@vie-serendipity
Copy link
Member Author

@rambohe-ch I add a check whether it's the first request after reconnection.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels May 23, 2024
@rambohe-ch
Copy link
Member

/LGTM

@rambohe-ch rambohe-ch merged commit 9e54b53 into openyurtio:master May 23, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants