-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: edgex component creation cause registration errors and core-command crash #2029
fix: edgex component creation cause registration errors and core-command crash #2029
Conversation
…and crash Signed-off-by: LavenderQAQ <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2029 +/- ##
=======================================
Coverage 55.32% 55.32%
=======================================
Files 183 183
Lines 17835 17835
=======================================
Hits 9867 9867
Misses 6942 6942
Partials 1026 1026
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
/backport release-v1.4 |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-v1.4
git worktree add -d .worktree/backport-2029-to-release-v1.4 origin/release-v1.4
cd .worktree/backport-2029-to-release-v1.4
git checkout -b backport-2029-to-release-v1.4
ancref=$(git merge-base 430b047d2c8023cb9bb2ffac5402ec2e7bee69ae 10b6c6cd18a6da2a815a9b160cfa0814fbf88711)
git cherry-pick -x $ancref..10b6c6cd18a6da2a815a9b160cfa0814fbf88711 |
/backport release-v1.4 |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-v1.4
git worktree add -d .worktree/backport-2029-to-release-v1.4 origin/release-v1.4
cd .worktree/backport-2029-to-release-v1.4
git checkout -b backport-2029-to-release-v1.4
ancref=$(git merge-base 430b047d2c8023cb9bb2ffac5402ec2e7bee69ae 10b6c6cd18a6da2a815a9b160cfa0814fbf88711)
git cherry-pick -x $ancref..10b6c6cd18a6da2a815a9b160cfa0814fbf88711 |
/backport release-v1.4 |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-v1.4
git worktree add -d .worktree/backport-2029-to-release-v1.4 origin/release-v1.4
cd .worktree/backport-2029-to-release-v1.4
git checkout -b backport-2029-to-release-v1.4
ancref=$(git merge-base 430b047d2c8023cb9bb2ffac5402ec2e7bee69ae 10b6c6cd18a6da2a815a9b160cfa0814fbf88711)
git cherry-pick -x $ancref..10b6c6cd18a6da2a815a9b160cfa0814fbf88711 |
What type of PR is this?
/kind bug
/sig iot
What this PR does / why we need it:
The default maxSurge value for k8s deployment is 25%, and when replicas is 1, maxSurge is 1 after rounding up. This results in the existence of 2 identical edgex components at the same time after a quick create + update operation, and edgex components use a registration mechanism. If a component preregisters and is terminated by workload, this causes the metadata component to scramble. This chaos manifests itself in the form of other components crashing all the time.
I updated
auto-collector
to directly inject the default maxSurge value of 0 into the config file and the issue was resolved.Which issue(s) this PR fixes:
Fixes #2028