1908

[MundaneImmortal]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1908

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.71%. Comparing base (56b874c) to head (8765ca6).
Report is 4 commits behind head on master.

Files	Patch %	Lines
...manager/controller/nodepool/nodepool_controller.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2007      +/-   ##
==========================================
+ Coverage   53.06%   54.71%   +1.64%     
==========================================
  Files         176      177       +1     
  Lines       21000    17271    -3729     
==========================================
- Hits        11144     9450    -1694     
+ Misses       8902     6849    -2053     
- Partials      954      972      +18     

Flag	Coverage Δ
unittests	54.71% <0.00%> (+1.64%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rambohe-ch]

@MundaneImmortal Thanks for posting pull request. you need to fix the golangci-lint errors. you can execute make lint command locally to check golangci-lint errors.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[MundaneImmortal]

@rambohe-ch Thanks for your feedback, I have fixed that and committed again.

[rambohe-ch]

/lgtm

[rambohe-ch]

@MundaneImmortal I am very appreciate for your first pull request, and i will merge it because all github actions(except codecov/patch) are passed.