fix bug when ServeHTTP panic #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
LGTM |
MrGirl
pushed a commit
to MrGirl/openyurt
that referenced
this pull request
Mar 29, 2022
fix bug when ServeHTTP panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
when client close the connection in advance, reserveproxy.ServeHTTP will panic, and everything after ServeHTTP will be skipped except "defer". so the element in reqChan(function WithMaxInFlightLimit) leaks.
reproduce:
curl '127.0.0.1:10261/apis/node.k8s.io/v1beta1/runtimeclasses?resourceVersion=1235193475&timeout=5m&timeoutSeconds=300&watch=true' -o /dev/null -v）MaxRequestInFlight)this pr moves the operation of the chan into defer, to make sure it will run after ServeHTTP
Ⅱ. Does this pull request fix one issue?
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
see the reproduce steps mentioned above
Ⅴ. Special notes for reviews