feat: improve hostNetwork mode of NodePool by adding NodeAffinity to pods with specified annotation (#1935) #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1959 +/- ##
==========================================
- Coverage 52.41% 52.37% -0.04%
==========================================
Files 173 174 +1
Lines 21015 20972 -43
==========================================
- Hits 11014 10985 -29
+ Misses 9051 9039 -12
+ Partials 950 948 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
huangchenzhao
force-pushed
the
issue1935
branch
from
542c5a7 to
eb92417
Compare
|
/rerun |
rambohe-ch
reviewed
Mar 4, 2024
rambohe-ch
reviewed
Mar 4, 2024
rambohe-ch
reviewed
Mar 4, 2024
|
@huangchenzhao filter hostnetworkpropagation also should be removed. |
…pods with specified annotation (openyurtio#1935)
huangchenzhao
force-pushed
the
issue1935
branch
from
eb92417 to
44ad71e
Compare
|
removed |
rambohe-ch
approved these changes
Mar 13, 2024
|
/lgtm |
vie-serendipity
pushed a commit
to vie-serendipity/openyurt
that referenced
this pull request
Mar 20, 2024
…pods with specified annotation (openyurtio#1935) (openyurtio#1959)
zyjhtangtang
pushed a commit
to zyjhtangtang/openyurt
that referenced
this pull request
Apr 16, 2024
…pods with specified annotation (openyurtio#1935) (openyurtio#1959)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
A mutating webhook is introduced in yurt-manager component for adding NodeAffinity to pods with
annotation["apps.openyurt.io/exclude-host-network-pool"] = true. The NodeAffinity indicates that the pods don't want to be scheduled to nodes in hostNetwork mode NodePool.Users should add
annotation ["apps.openyurt.io/exclude-host-network-pool"] = truemanually to pods if they don't want to run pods on edge nodes in hostNetwork mode nodepool.Which issue(s) this PR fixes:
Fixes #1935