-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add yurtappset v1beta1 #1939
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luc99hen
force-pushed
the
add_yurtappset_v1beta1
branch
2 times, most recently
from
January 31, 2024 09:05
87059cb
to
59d4a28
Compare
luc99hen
force-pushed
the
add_yurtappset_v1beta1
branch
2 times, most recently
from
January 31, 2024 11:37
3205829
to
f2e746c
Compare
/rerun |
luc99hen
force-pushed
the
add_yurtappset_v1beta1
branch
2 times, most recently
from
February 4, 2024 02:38
ec9d03d
to
59564e6
Compare
/rerun |
rambohe-ch
reviewed
Feb 5, 2024
rambohe-ch
reviewed
Feb 5, 2024
e2e fail due to the compatibility issues implemented in convert logic, currently known issues are:
|
luc99hen
force-pushed
the
add_yurtappset_v1beta1
branch
from
February 5, 2024 07:48
59564e6
to
c3bfe1a
Compare
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 11 New issues |
rambohe-ch
approved these changes
Feb 5, 2024
/lgtm |
zyjhtangtang
pushed a commit
to zyjhtangtang/openyurt
that referenced
this pull request
Apr 16, 2024
Co-authored-by: cl382465 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Following the proposal #1890 #1931
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
@rambohe-ch
Does this PR introduce a user-facing change?
other Note