Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add yurtappset v1beta1 #1939

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

luc99hen
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Following the proposal #1890 #1931

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@rambohe-ch

Does this PR introduce a user-facing change?


other Note

@luc99hen luc99hen force-pushed the add_yurtappset_v1beta1 branch 2 times, most recently from 87059cb to 59d4a28 Compare January 31, 2024 09:05
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 282 lines in your changes are missing coverage. Please review.

Comparison is base (da03883) 52.04% compared to head (c3bfe1a) 52.39%.
Report is 2 commits behind head on master.

Files Patch % Lines
...ger/controller/yurtappset/yurtappset_controller.go 49.63% 118 Missing and 21 partials ⚠️
...r/yurtappset/workloadmanager/deployment_manager.go 54.46% 37 Missing and 14 partials ⚠️
...ebhook/yurtappset/v1beta1/yurtappset_validation.go 27.50% 21 Missing and 8 partials ⚠️
pkg/yurtmanager/controller/yurtappset/revision.go 74.74% 20 Missing and 5 partials ⚠️
...ager/controller/yurtappset/workloadmanager/util.go 78.31% 14 Missing and 4 partials ⚠️
...er/controller/yurtappset/workloadmanager/tweaks.go 87.32% 6 Missing and 3 partials ⚠️
pkg/yurtmanager/controller/yurtappset/utils.go 83.87% 3 Missing and 2 partials ⚠️
...tmanager/controller/util/refmanager/ref_manager.go 0.00% 4 Missing ⚠️
...r/webhook/yurtappset/v1beta1/yurtappset_handler.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1939      +/-   ##
==========================================
+ Coverage   52.04%   52.39%   +0.34%     
==========================================
  Files         174      173       -1     
  Lines       21213    21007     -206     
==========================================
- Hits        11040    11006      -34     
+ Misses       9199     9051     -148     
+ Partials      974      950      -24     
Flag Coverage Δ
unittests 52.39% <61.36%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luc99hen
Copy link
Member Author

/rerun

@luc99hen luc99hen force-pushed the add_yurtappset_v1beta1 branch 2 times, most recently from ec9d03d to 59564e6 Compare February 4, 2024 02:38
@rambohe-ch
Copy link
Member

/rerun

@luc99hen
Copy link
Member Author

luc99hen commented Feb 5, 2024

e2e fail due to the compatibility issues implemented in convert logic, currently known issues are:

  1. v1alpha1 status replicas, readyReplicas can not obtained from v1beta1, use estimate workload*defaultReplica
  2. v1alpha1 status currenetRevision conversion logic missing
  3. v1alpha1 spec selector can not obtained from v1beta1 directly, use deployment/statefulset selector

@luc99hen luc99hen force-pushed the add_yurtappset_v1beta1 branch from 59564e6 to c3bfe1a Compare February 5, 2024 07:48
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

11 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Feb 5, 2024
@rambohe-ch rambohe-ch merged commit 367e2b5 into openyurtio:master Feb 5, 2024
13 checks passed
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants