Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve configuration of concurrent delegate-lease workers (#1918) #1927

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

huangchenzhao
Copy link
Member

What type of PR is this?

/kind good-first-issue
/kind feature

What this PR does / why we need it:

improve the configuration of concurrent delegate-lease worker in yurt-manager component

Which issue(s) this PR fixes:

Fixes #1918

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (81d21b7) 52.16% compared to head (6bbeadc) 52.16%.

Files Patch % Lines
...rdinator/delegatelease/delegatelease_controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1927   +/-   ##
=======================================
  Coverage   52.16%   52.16%           
=======================================
  Files         172      172           
  Lines       20874    20872    -2     
=======================================
  Hits        10888    10888           
+ Misses       9018     9017    -1     
+ Partials      968      967    -1     
Flag Coverage Δ
unittests 52.16% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Jan 18, 2024
@rambohe-ch rambohe-ch merged commit c904e63 into openyurtio:master Jan 18, 2024
12 of 13 checks passed
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]improve configuration of concurrent delegate-lease workers
2 participants