fix: remove custom signal handler for concurrent reclaims #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangxye <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1889 +/- ##
=======================================
Coverage 52.20% 52.20%
=======================================
Files 172 172
Lines 20844 20844
=======================================
Hits 10881 10881
Misses 8999 8999
Partials 964 964
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/rerun |
1 similar comment
|
/rerun |
rambohe-ch
approved these changes
Jan 2, 2024
|
/lgtm |
zyjhtangtang
pushed a commit
to zyjhtangtang/openyurt
that referenced
this pull request
Apr 16, 2024
…#1889) Signed-off-by: wangxye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/sig iot
/kind bug
What this PR does / why we need it:
Remove exit reclaim logic to avoid iot-dock actively delete resources on edgex due to extreme concurrency.
Which issue(s) this PR fixes:
Fixes #1887
Special notes for your reviewer:
/assign @LavenderQAQ @Rui-Gan
Does this PR introduce a user-facing change?
Users need to take the initiative to remove cr resources: device/deviceprofile/deviceservice.