Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yurt-manager): add clusterrole for nodes/status subresources #1884

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

qclc
Copy link
Member

@qclc qclc commented Dec 28, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

If role of nodes/status resource is missing, the operation of yurt-manager(nodelifecycle-controllerr) to update the node status is prohibited.

Which issue(s) this PR fixes:

Fixes #1882

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df8974f) 52.14% compared to head (0eeef17) 52.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
+ Coverage   52.14%   52.19%   +0.05%     
==========================================
  Files         172      172              
  Lines       20841    20841              
==========================================
+ Hits        10867    10879      +12     
+ Misses       9009     8998      -11     
+ Partials      965      964       -1     
Flag Coverage Δ
unittests 52.19% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

/rerun

@rambohe-ch
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] clusterrole yurt-manager-role in yurt-manager helm chart lacks nodes/status resource
2 participants